search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.45k stars 141 forks source link

reviewer status doesn't reflect consecutive review requests #693

Open macovsky opened 2 days ago

macovsky commented 2 days ago

the whole "strongest review state" https://github.com/pwntester/octo.nvim/blob/master/lua/octo/utils.lua#L143-L155 doesn't reflect current review state per reviewer as github itself does: if reviewer commented/requested changes and then author resolves comments and re-request the review github diplays reviewer with "requested" state but octo simply shows "strongest" state and ignores consequent review requests (that's a slight problem because I don't see if I need to re-request review or not)

IMO we would want to either match github and display the latest state (because octo is for github anyways) or add the latest state to the "strongest state", so if reviewer commented/requested changes first and then was re-requested to review we would display two states close to reviewer: the first one and then pending.

https://github.com/pwntester/octo.nvim/issues/670#issuecomment-2466151979

macovsky commented 2 days ago

@pwntester @wd60622 what do you think? I'm ready to fix this, I personally think to match github and display the latest reviewer status.