search

px-amaac / KZFR

KZFR Radio Streaming App
2 stars 7 forks source link

Gap under show image [for next version?] #72

Closed trvbr closed 9 years ago

trvbr commented 9 years ago

When the header is fully expanded, it seems that the image is truncated, and there is a white space under it. Maybe this is default behavior so that the black title text is guaranteed to be visible? Though, even so, it ends up making the alignment a bit weird.

Again, this might be hard to fix if this is based on a pre-built Android template/library, but worth a shot to figure out a way to improve it.

screenshot_2015-07-16-19-06-01

px-amaac commented 9 years ago

I did this. The layout is specified this way so you can see the title. Otherwise with all the different images and colors there would be some that look good and some where you would not be able to see the title. I had it expanding to where it is at now and I extended the layout to fit the title. The image is not truncated it is center cropped.

px-amaac commented 9 years ago

I think i can move the title around if that is what you are worried about. Where it is now is default for the collapsing title view. If i remember right I can add padding to it to move it around.

trvbr commented 9 years ago

Okay cool. Was firstly curious about whether it was the Android library. Then secondly of course just wanted it more aligned. My itch for alignment is relentless. :) ᐧ

On Fri, Jul 17, 2015 at 12:04 AM, Aaron notifications@github.com wrote:

I think i can move the title around if that is what you are worried about. Where it is now is default for the collapsing title view. If i remember right I can add padding to it to move it around.

— Reply to this email directly or view it on GitHub https://github.com/px-amaac/KZFR/issues/72#issuecomment-122199336.