Add tuple return type - Githubissues

py-stockfish / stockfish

Integrates the Stockfish chess engine with Python (Official fork)

https://py-stockfish.github.io/stockfish/

MIT License

29 stars 8 forks source link

Add tuple return type #69

Closed evanjhoward11 closed 1 month ago

evanjhoward11 commented 3 months ago

Add tuple as a return type to get_wdl_stats. Add one test to ensure return type is a tuple when argument get_as_tuple=True. Closes issue #46.

github-actions[bot] commented 3 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
stockfish
models.py
Project Total

This report was generated by python-coverage-comment-action

johndoknjas commented 3 months ago

Thanks for your PR @evanjhoward11! I've added a few suggestions but nothing major.

evanjhoward11 commented 2 months ago

Sorry for the late reply. I added the necessary changes that @johndoknjas mentioned. Not sure why the Linux-related tests are failing. Perhaps it has something to do with the files I added to my local folder for testing purposes (main.py, stockfish exe, and .gitignore)?