search

pyOpenSci / lessons

A repo containing lessons used in pyOpenSci training.
https://www.pyopensci.org/lessons
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

feat(activity): add activity 2 #17

Closed lwasser closed 1 month ago

lwasser commented 1 month ago

This is the second activity in the workshop. It's complete short of the answers to the OYO sections. i have an answer key script as well that i can push separately.

lwasser commented 1 month ago

NOTE: the CI issues will be fixed when some of the other pr's are merged. I'm worrying less about that now and more about content!!

lwasser commented 1 month ago

Cool - CI is failing with things are are fixed in #18 #13 i am going to merge this soon after one last round of revisions and adding answers to the OYOs

lwasser commented 1 month ago

thank you, @ucodery. If you want to have a look at a preview of the published (ci) page - it's here - https://output.circle-artifacts.com/output/job/b18a4bf1-8f83-4764-a52b-e0e61a07f909/artifacts/0/html/clean-modular-code/activity-2/clean-code-activity-2.html I've made small edits and clarified things which is why it may be hard to identify what has changed.

The big change here is that I rewrote the POSIX path section and added examples. I'm hopeful that makes it more clear! Thank you for the review comments - things were not worded well before.

lwasser commented 1 month ago

I am going to merge this PR, rebase and focus more time on activity 3 next week. Thank you again @ucodery for all of the input!! the CI issues are related to other lessons not in this PR. They will all get fixed once things are merged! Lesson dev is iterative as we focus on the content and move things around accordingly.