Closed ladc closed 3 months ago
Fantastic, @ladc! I will have a look at it after the weekend. :)
Thanks! There's still somewhat of a jump, but not sure if we can entirely avoid it.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.00%. Comparing base (
b4b41a5
) to head (df2ce0e
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Quick thought: would it perhaps help to simply "fade in" in few time steps after t0 from zeros to the NWP values outside the radar mask? This way, you would ensure a smooth transition
Edit: on a second thought and more careful read, you're approach achieves the same in a more elegant way, way to go!
Here's just a final animation with and without the smoothing between nwc and nwp (mask boundary fix by Simon) row 1: "control" (other branch, not yet finished) - member - mean (without smoothing) row 2: observation - member with smoothing - mean with smoothing
The resampling now allows the presence of nans. For pixel locations with a nan, both arrays are ignored. The probability matching has an extra argument ignore_indices which are left untouched.
This functionality is added so that the values outside the radar mask, where there is only NWP data, don't affect the distribution of rainfall inside the mask. In the case of high intensity in NWP but not in the radar for example, you'd otherwise get a huge jump in intensity due to the extremes affecting the radar nowcast area.
Result is in the top right and bottom left: