pyapp-kit / superqt

Missing widgets and components for Qt-python
https://pyapp-kit.github.io/superqt/
BSD 3-Clause "New" or "Revised" License
215 stars 38 forks source link

Fix float value error in pyqt configuration #106

Closed mstabrin closed 2 years ago

mstabrin commented 2 years ago

In the pyqt5 configuration, the QLabeledSlider throws an error due to QDoubleSpinBox returning a float rather than an int.

Here I propose to add a proxy _setValue function which does the conversion :)

codecov[bot] commented 2 years ago

Codecov Report

Merging #106 (c55058e) into main (39c10aa) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   84.91%   84.93%   +0.01%     
==========================================
  Files          30       30              
  Lines        2387     2389       +2     
==========================================
+ Hits         2027     2029       +2     
  Misses        360      360              
Impacted Files Coverage Δ
src/superqt/sliders/_labeled.py 79.89% <100.00%> (+0.10%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mstabrin commented 2 years ago

Hello @tlambert03, I was wondering if there is a fixed release cycle for superqt or if releases are created on demand. I am just wondering when I can expect this change to be available via pip to fix the current problems we face within napari with the Point size slider :)

tlambert03 commented 2 years ago

they're done as needed. sorry for the delay on this one. will release today

tlambert03 commented 2 years ago

oh actually... looks like I tried to release 24 days ago and missed that one of the jobs failed: https://github.com/napari/superqt/actions/runs/2727679828

rerunning now