search

pyapp-kit / superqt

Missing widgets and components for Qt-python
https://pyapp-kit.github.io/superqt/
BSD 3-Clause "New" or "Revised" License
215 stars 38 forks source link

Fix crazy animation loop on Qcollapsible #84

Closed tlambert03 closed 2 years ago

tlambert03 commented 2 years ago

the fix for child widget resizing in #72 can, in some cases, cause a crazy collapse/expand animation loop. This PR fixes that by turning off animations in the case where we're simply updating the height of the collapsible due to a child event

codecov[bot] commented 2 years ago

Codecov Report

Merging #84 (dc6d986) into main (68248c9) will increase coverage by 0.06%. The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   84.51%   84.58%   +0.06%     
==========================================
  Files          29       29              
  Lines        2325     2329       +4     
==========================================
+ Hits         1965     1970       +5     
+ Misses        360      359       -1
Impacted Files Coverage Δ
src/superqt/collapsible/_collapsible.py 93.90% <81.81%> (+0.31%) :arrow_up:
src/superqt/sliders/_range_style.py 72.18% <0.00%> (+0.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68248c9...dc6d986. Read the comment docs.