pycom / pycom-micropython-sigfox

A fork of MicroPython with the ESP32 port customized to run on Pycom's IoT multi-network modules.
MIT License
197 stars 167 forks source link

RegionCN470.c: Fix RegionCN470ChannelsRemove() #476

Closed robert-hh closed 1 year ago

robert-hh commented 3 years ago

This function was empty before, doing nothing but returning an error code, which was ignored, as it seems. Now it removes a channel from the Channels table as supposed.

peter-pycom commented 3 years ago

some context https://forum.pycom.io/topic/6303/lopy4-change-uplink-channels-by-itself/19

robert-hh commented 3 years ago

That's what initiated the PR for CN470. The change for EU433 appeared on the road while doing the CN470 cause analysis.

robert-hh commented 3 years ago

Not fixed yet in 1.20.3.b3

robert-hh commented 1 year ago

Closing, since the product is not supported any more.