Use credential-ID instead/in-addition of description when creating a node

pycontribs / jenkinsapi

A Python API for accessing resources and configuring Hudson & Jenkins continuous-integration servers

http://pypi.python.org/pypi/jenkinsapi

MIT License

858 stars 485 forks source link

Use credential-ID instead/in-addition of description when creating a node #766

Open toabctl opened 4 years ago

toabctl commented 4 years ago

ISSUE TYPE

Feature Idea

Jenkinsapi 0.3.11

Jenkins 2.164.3

SUMMARY

When creating a new node with create_node(), the node_dict expects a parameter called credential_description. It would be nice if also the credential ID could be given here.

acolombier commented 4 years ago

We are currently blocked from using jenkinsapi because of this issue.

I just created PR #798 which is supposed to fix it, please let me know if that can merge ASAP.