search

pycontribs / jenkinsapi

A Python API for accessing resources and configuring Hudson & Jenkins continuous-integration servers
http://pypi.python.org/pypi/jenkinsapi
MIT License
857 stars 483 forks source link

CLI type hinting and minor refactor #839

Closed thealpinegoat closed 1 year ago

thealpinegoat commented 1 year ago

Problem: The type hinting for jenkinsapi.command_line is a little lacking. In addition, the use of asserts in non-test code is undesirable.

Solution: Introduce type hinting following PEP-484 for straddling code and refactor asserts to use proper conditionals instead.

lechat commented 1 year ago

Thanks!