pycontw / pycontw-frontend

The official website for PyCon TW 🐍
16 stars 36 forks source link

refactor(sponsor): non-i18n content adjustment #572

Closed wanyewei closed 3 months ago

wanyewei commented 3 months ago

Types of changes

Description

Remove content that does not require i18n conversion.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Into pages/sponsor/index.vue
  2. Check line 54 in index.vue if $t('terms.contact') become sponsorship@python.tw or not
  3. Into i18n/sposor/index.i18n.js
  4. Check if terms: {contact: 'sponsorship@python.tw', } has been removed from both en-us and zh-hant in index.i18n.js.
  5. Into http://localhost:3000/2024/en-us/sponsor
  6. Check if sponsorship@python.tw showed normally or not
netlify[bot] commented 3 months ago

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
Latest commit 2757a61d69efff9b739827abf807f24effbbf9bd
Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/66d2c10c930e1d000853e898
Deploy Preview https://deploy-preview-572--classy-granita-bc2b5a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
Latest commit 2757a61d69efff9b739827abf807f24effbbf9bd
Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66d2c10cb9d1f60008f299d3
Deploy Preview https://deploy-preview-572--zesty-gnome-f04144.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SivanYeh commented 3 months ago

index.vue上把{{ $t('terms.contact') }}取代成sponsorship@python.tw的調整方向確實對了。 但超連結的效果卻消失了,思考一下大概是什麼原因(hint: 跟你index.i18n.js調整有關

可以參考一下privacy-policytickets上對organizers@python.tw的處理方法