Closed GoogleCodeExporter closed 8 years ago
This may be fixed in the 1.0.5b1 code or svn
Original comment by kdeko...@gmail.com
on 21 Nov 2011 at 3:12
As reported in Debian's #658791 this still seems to be issue with 1.0.5. I'm
also able to reproduce it. The output of gnome-mplayer -v run from nautilus is
attached.
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658791
Original comment by s.ramac...@gmail.com
on 10 Feb 2012 at 11:47
Attachments:
But it also does work. The gnome-mplayer output is attached again.
The notable difference is that the first time it was "is block 1" and the
second time "is block 0". It's actually the g_stat call in src/main.c:1051 that
fails and thus the data in buf is not useful. If one is lucky and buf.st_mode
has the right value the file is played, otherwise it doesn't.
Original comment by s.ramac...@gmail.com
on 10 Feb 2012 at 12:36
Attachments:
If gvfs is not reporting things correctly, then it is probably a bug in gvfs. I
will look into it, but I expect that there won't be much I can do.
Original comment by kdeko...@gmail.com
on 10 Feb 2012 at 3:24
Running gnome-mplayer with strace shows that g_stat is called with NULL as
first argument. So this is not a gvfs issue.
The interesting part from the strace output:
stat64(NULL, 0xbfcdff8c) = -1 EFAULT (Bad address)
write(1, "opening /home/sebastian/.gvfs/SF"..., 86) = 86
write(1, "is block 0\n", 11) = 11
write(1, "is character 1\n", 15) = 15
write(1, "is reg 0\n", 9) = 9
write(1, "is dir 0\n", 9) = 9
write(1, "playlist 0\n", 11) = 11
write(1, "embedded in window id 0x0\n", 26) = 26
Original comment by s.ramac...@gmail.com
on 10 Feb 2012 at 3:46
Ok, I have patched this in SVN, r2207 and additionally in r2208, but this only
works around gvfs/gio reporting a null value, when it actually should not be.
So I'm just band-aiding the real issue. The fact that it works sometimes and
not others means there is something else deeper to look at.
Original comment by kdeko...@gmail.com
on 10 Feb 2012 at 4:05
Thanks, I'll try it later and report back.
The fact that it works sometimes is due to the fact that buf is initialized
with random data. If g_stat fails the data is not touched. And as long as the
block flag is not set, everything just works fine.
Original comment by s.ramac...@gmail.com
on 10 Feb 2012 at 4:15
in r2209 I set the buf to zeros. I don't see that issue on my machine, because
I believe Fedora does that by default.
Original comment by kdeko...@gmail.com
on 10 Feb 2012 at 4:31
I've tried the code from svn now. It works for regular files (since S_ISREG is
never checked) but not for directories since st_mode is always 0.
I tried to come up with a patch on my one that uses GFileAttribute. It
correctly detects the mode and st_mode gets the right value. The patch is
attached.
Original comment by s.ramac...@gmail.com
on 10 Feb 2012 at 7:40
Attachments:
Patch looks good to me, applied
Original comment by kdeko...@gmail.com
on 10 Feb 2012 at 7:49
Original comment by kdeko...@gmail.com
on 5 Apr 2012 at 1:24
Original issue reported on code.google.com by
hyper...@gmail.com
on 21 Nov 2011 at 10:56