pydantic / pydantic-core

Core validation logic for pydantic written in rust
MIT License
1.45k stars 247 forks source link

fix: implemented fallback if inline-snapshot is used with pypy #1533

Closed 15r10nk closed 2 weeks ago

15r10nk commented 3 weeks ago

Change Summary

Implemented fallback if inline-snapshot is used with pypy (or any other none cpython implementation of python). I hope to support pypy in the future but I don't know how long this will take.

Related issue number

fix #1534

Checklist

Selected Reviewer: @davidhewitt

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.36%. Comparing base (ab503cb) to head (4bc75c5). Report is 224 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1533 +/- ## ========================================== - Coverage 90.21% 89.36% -0.85% ========================================== Files 106 112 +6 Lines 16339 17928 +1589 Branches 36 40 +4 ========================================== + Hits 14740 16022 +1282 - Misses 1592 1886 +294 - Partials 7 20 +13 ``` [see 54 files with indirect coverage changes](https://app.codecov.io/gh/pydantic/pydantic-core/pull/1533/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pydantic/pydantic-core/pull/1533?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pydantic/pydantic-core/pull/1533?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic). Last update [2419981...4bc75c5](https://app.codecov.io/gh/pydantic/pydantic-core/pull/1533?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic).
codspeed-hq[bot] commented 3 weeks ago

CodSpeed Performance Report

Merging #1533 will not alter performance

Comparing 15r10nk:inline-snapshot-pypy-fix (4bc75c5) with main (2419981)

Summary

✅ 155 untouched benchmarks

15r10nk commented 2 weeks ago

please review.