search

pydantic / pydantic-core

Core validation logic for pydantic written in rust
MIT License
1.45k stars 247 forks source link

Use `uv` in `Makefile` and CI #1546

Closed sydney-runkle closed 1 week ago

sydney-runkle commented 1 week ago

Follow up to https://github.com/pydantic/pydantic-core/pull/1545

sydney-runkle commented 1 week ago

Putting a pause on this for now, will resume tomorrow

sydney-runkle commented 1 week ago

I don't think we should need those .txt files with the updates to pyproject.toml - I was using the install groups successfully 👍

sydney-runkle commented 1 week ago

I think the codspeed fix might be that we need to add back the install python

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #1546 will degrade performances by 12.27%

Comparing makefile-uv (d940668) with main (c9d01c3)

Summary

❌ 1 regressions
✅ 154 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main makefile-uv Change
❌ test_list_of_strs_json_uncached 408.2 µs 465.3 µs -12.27%
davidhewitt commented 1 week ago

🎉

@sydney-runkle, if you are happy with this being good enough, let's merge and iterate any small improvements in follow ups.

sydney-runkle commented 1 week ago

Yep, let's merge. Thanks for finishing this up @davidhewitt