Closed rdbisme closed 4 months ago
Yes it is building with Numpy 2.0rc1 but the test failures above are due to a change in API in Numpy 2.0 at runtime specifically the meaning of copy.
In Numpy 2.0, you should use copy=None
to mean don't copy if possible - copy=False
will now error if it can't avoid copying the array.
Care to push a PR which fixes the API change (and maybe edits the tests correctly?)
You neither build nor test with numpy 2.0.0rc1 in your tests though: https://github.com/pydata/bottleneck/actions/runs/8952001350/job/24588934895#step:4:21
This is what happens if you run the tests with 1.4.0rc4 and numpy 2.0.0rc1: