pydata / pydata-google-auth

A package providing helpers for authenticating to Google APIs.
https://pydata-google-auth.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
37 stars 17 forks source link

Shipped versioneer.py is too old for Python 3.12 #74

Open bnavigator opened 5 months ago

bnavigator commented 5 months ago

Replacing it by a more recent version fixes it. But you might also consider migrating to another versioning tool and PEP517 build system.

[   15s] + /usr/bin/python3.12 setup.py build '--executable=/usr/bin/python3.12 -s'
[   15s] /home/abuild/rpmbuild/BUILD/pydata-google-auth-1.8.2/versioneer.py:433: SyntaxWarning: invalid escape sequence '\s'
[   15s]   ] = '''
[   16s] Traceback (most recent call last):
[   16s]   File "/home/abuild/rpmbuild/BUILD/pydata-google-auth-1.8.2/setup.py", line 29, in <module>
[   16s]     version=versioneer.get_version(),
[   16s]             ^^^^^^^^^^^^^^^^^^^^^^^^
[   16s]   File "/home/abuild/rpmbuild/BUILD/pydata-google-auth-1.8.2/versioneer.py", line 1525, in get_version
[   16s]     return get_versions()["version"]
[   16s]            ^^^^^^^^^^^^^^
[   16s]   File "/home/abuild/rpmbuild/BUILD/pydata-google-auth-1.8.2/versioneer.py", line 1452, in get_versions
[   16s]     cfg = get_config_from_root(root)
[   16s]           ^^^^^^^^^^^^^^^^^^^^^^^^^^
[   16s]   File "/home/abuild/rpmbuild/BUILD/pydata-google-auth-1.8.2/versioneer.py", line 347, in get_config_from_root
[   16s]     parser = configparser.SafeConfigParser()
[   16s]              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[   16s] AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?
[   16s] error: Bad exit status from /var/tmp/rpm-tmp.mxBgip (%build)
tswast commented 3 months ago

Thanks for the report!

I'm not super satisfied with versioneer, either. I've used https://github.com/googleapis/release-please/tree/main?tab=readme-ov-file#setting-up-release-please in other repos.

Do you have any other recommendations?