pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
623 stars 322 forks source link

Add CI test for docs build of selected Scientific Python projects #1851

Open melissawm opened 6 months ago

melissawm commented 6 months ago

To avoid breakage and unexpected problems when a release is made, we could add a CI job that builds the docs pages for a list of selected projects and verifies that the output is as expected. Ideally, it would run as a cron job (and not on every CI run).

melissawm commented 5 months ago

The following projects seem like reasonable candidates:

12rambau commented 5 months ago

What would be the "expected output" ? It's very difficult to get CI to check for how things render on our own website already.

trallard commented 5 months ago

I think there are two things that could be tested

  1. That the build process of third party docs is successful - this can be easily checked in CI and mostly helps us catch any unintentional breaking changes introduced by us or some of our dependencies.
  2. Visually inspecting the build - this is definitely hard from a CI only POV and unless we have visual regression tests (which would be a great amount of work on our end to write and maintain as we continue to work on the theme) there is no way to do but through a manual check. So IMHO this should be out of our scope.

So we should only focus on 1. for the time being

melissawm commented 5 months ago

For completeness, it may be also helpful to have https://github.com/executablebooks/sphinx-book-theme

drammock commented 5 months ago

For completeness, it may be also helpful to have https://github.com/executablebooks/sphinx-book-theme

yep. We recently broke something for them (https://github.com/pydata/pydata-sphinx-theme/issues/1875#issuecomment-2162995192) so definitely makes sense to include