Closed DeaMariaLeon closed 3 months ago
Comparing DeaMariaLeon:bench2
(5c34b67) with main
(0612373)
โ
14
untouched benchmarks
๐ 14
new benchmarks
Benchmark | main |
DeaMariaLeon:bench2 |
Change | |
---|---|---|---|---|
๐ | test_elemwise_broadcast[side=100-add] |
N/A | 14 ms | N/A |
๐ | test_elemwise_broadcast[side=100-mul] |
N/A | 3.1 ms | N/A |
๐ | test_elemwise_broadcast[side=1000-add] |
N/A | 14.9 s | N/A |
๐ | test_elemwise_broadcast[side=1000-mul] |
N/A | 73.5 ms | N/A |
๐ | test_elemwise_broadcast[side=500-add] |
N/A | 1.7 s | N/A |
๐ | test_elemwise_broadcast[side=500-mul] |
N/A | 12.5 ms | N/A |
๐ | test_index_fancy[side=100] |
N/A | 3.5 ms | N/A |
๐ | test_index_scalar[side=100] |
N/A | 481.2 ยตs | N/A |
๐ | test_index_slice2[side=100] |
N/A | 1.6 ms | N/A |
๐ | test_index_slice3[side=100] |
N/A | 1.4 ms | N/A |
๐ | test_index_slice[side=100] |
N/A | 1.1 ms | N/A |
๐ | test_matmul[side=1000] |
N/A | 39.9 ms | N/A |
๐ | test_matmul[side=100] |
N/A | 2.7 ms | N/A |
๐ | test_matmul[side=500] |
N/A | 8 ms | N/A |
@hameerabbasi Regarding:
SEED = 42 I'd import this from a central place, so it can be changed just once.
It's not working the way I did it on this commit. But locally I did something else: I put them inside a conftest.py
. Which it seems to work, except that I noticed that SEED and DENSITY vary on other files. Like elemwise_example.py
, matmul_example.py
, etc.
For seed, let's unify it. For density, we can leave it constant in each file where it's constant; and change it where it should be changed.
For seed, let's unify it.
What does this mean? set just one value for all the tests, on all the files? Set the value on conftest.py
?
Set the value on
conftest.py
?
Set one value for everything in some central place.
I'll do the out-of-band changes on another PR if that's fine with you then.
What type of PR is this? (check all applicable)
Related issues
Checklist
Please explain your changes below.
Adapted benchmarks from original file
benchmark_coo.py
that was used to benchmark withasv
. Now benchmarking withcodspeed
.