Closed eric-wieser closed 4 years ago
Check out this pull request on
Review Jupyter notebook visual diffs & provide feedback on notebooks.
Powered by ReviewNB
Merging #382 into master will increase coverage by
0.10%
. The diff coverage is80.00%
.
@@ Coverage Diff @@
## master #382 +/- ##
==========================================
+ Coverage 77.52% 77.63% +0.10%
==========================================
Files 16 16
Lines 4285 4256 -29
==========================================
- Hits 3322 3304 -18
+ Misses 963 952 -11
Impacted Files | Coverage Δ | |
---|---|---|
galgebra/lt.py | 59.77% <50.00%> (+0.14%) |
:arrow_up: |
galgebra/printer.py | 78.70% <88.88%> (+0.42%) |
:arrow_up: |
galgebra/mv.py | 75.15% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 61763a0...3c5d15f. Read the comment docs.
Rebased. Notebooks need regenerating.
Looks like I lost some cleanup in the rebase too
The former can be used in math mode, but the latter is only legal in text mode. The sympy latex printer expects all results to be usable in math mode.
This resulted in a bug when attempting to use something like:
Before this change:
After this change:
Builds upon #379.