pygae / galgebra

Symbolic Geometric Algebra/Calculus package for SymPy :crystal_ball:
https://galgebra.rtfd.io/
BSD 3-Clause "New" or "Revised" License
233 stars 62 forks source link

Change the latex printing of Mv to use aligned instead of align* #382

Closed eric-wieser closed 4 years ago

eric-wieser commented 4 years ago

The former can be used in math mode, but the latter is only legal in text mode. The sympy latex printer expects all results to be usable in math mode.

This resulted in a bug when attempting to use something like:

from IPython.display import Math
from sympy import latex
Math(latex((F.Fmt(3,'F'), F.Fmt(3,'F'))))

Before this change:

image

After this change:

image

Builds upon #379.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

codecov[bot] commented 4 years ago

Codecov Report

Merging #382 into master will increase coverage by 0.10%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   77.52%   77.63%   +0.10%     
==========================================
  Files          16       16              
  Lines        4285     4256      -29     
==========================================
- Hits         3322     3304      -18     
+ Misses        963      952      -11     
Impacted Files Coverage Δ
galgebra/lt.py 59.77% <50.00%> (+0.14%) :arrow_up:
galgebra/printer.py 78.70% <88.88%> (+0.42%) :arrow_up:
galgebra/mv.py 75.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61763a0...3c5d15f. Read the comment docs.

eric-wieser commented 4 years ago

Rebased. Notebooks need regenerating.

eric-wieser commented 4 years ago

Looks like I lost some cleanup in the rebase too