search

pygame-community / pygame-ce

🐍🎮 pygame - Community Edition is a FOSS Python library for multimedia applications (like games). Built on top of the excellent SDL library.
https://pyga.me
939 stars 155 forks source link

Fix test_inflate_ip__larger. #3098

Closed avpai-dinosaur closed 2 months ago

avpai-dinosaur commented 2 months ago

This test case was not checking what it was supposed to check (duplicate code of test_inflate_ip__smaller).

Fixes #3096

bilhox commented 2 months ago

LGTM. The docstrings for tests of pygame.Rect.scale_by could also benefit from updating them, but it's probably out of scope of this PR.

Indeed I can see that for certain tests. I think it's something a bit linked to the topic of this PR. So I would suggest a change there as gresm mentionned it. Otherwise it will not be fixed in a near future.