pyload / pyload

The free and open-source Download Manager written in pure Python
https://pyload.net
Other
3.29k stars 710 forks source link

Config option `fallback` not found, use default `True` #1722

Closed scrimpy closed 5 years ago

scrimpy commented 9 years ago

05.08.2015 19:41:32 WARNING HOSTER UploadedTo[8]: Premium download failed | No file downloaded 33 05.08.2015 19:41:32 DEBUG HOSTER UploadedTo[8]: Config option fallback not found, use default True 32 05.08.2015 19:41:32 INFO HOSTER UploadedTo[8]: Checking file...

scrimpy commented 9 years ago

in multiconfig setup only the first copy runs without errors /usr/share/pyload & /root/.pyload runs /usr/share/pyload2 & /root/.pyload2 bugs

scrimpy commented 9 years ago

no debug output is created.

bistory commented 9 years ago

Same problem with a regularly auto-updated Pyload...

scrimpy commented 9 years ago

ok yes, just checked that link, and both setups gave that error.

scrimpy commented 9 years ago

ok i think im change flexget config to use jdownloader now. have fun with this broken code that maybe will run in a year or two again. bye

1337sup3rh4x0r commented 9 years ago

It is pretty disrespectful towards the people who maintain pyload in their free time when you say something like this.

bistory commented 9 years ago

+1

1337sup3rh4x0r commented 9 years ago

I noticed that the source of SimpleHoster.py mentions two config options, one of them is fallback:

__config__  = [("use_premium", "bool", "Use premium account if available"          , True),
               ("fallback"   , "bool", "Fallback to free download if premium fails", True)]

In the config page of pyload for the uploadedTo plugin I can however only set the first. Does this maybe have something to do with this issue?

GammaC0de commented 9 years ago

@1337sup3rh4x0r this happens for chk_filesize config too:

Config option `chk_filesize` not found, use default `None`

The reason for this is because PluginManager deletes the config because "internals have no config": PluginManager.py#L156:

                # internals have no config
                if folder == "internal":
                    self.core.config.deleteConfig(name)
                    continue

SimpleHoster is indeed internal plugin therefor the config for use_premium, fallback and chk_filesize gets deleted.

This happens in v0.4.10 too (see Plugin.py#L146)

@vuolter for you consideration.

joberreiter commented 9 years ago

I've an additional question that may related to this behaviour:

Is this the reason why the config options use_subfolder and subfolder_per_package are already defined in many plugins?

If yes, how does one enable or disable the use of subfolder creation on a global level, without setting every plugin accordingly? E.g. if one disable subfolders globally (Config/General/General/Create folder for each package = off) and all plugins have their default value use_subfolder = True, what is the resulting action? Subfolders or not?

I'm aware that this can't be compared to chk_filesize, fallback, or use_premium as those don't have their according global settings (as far as I remember).

Anyway, maybe it would be better to change the text of Config option *** not found, use default ***, since 'not found' implicits to be an error message to the average user, isn't it? Maybe something like Plugin config option *** not set, using global value *** would be more unambiguous.

GammaC0de commented 9 years ago

@joberreiter Yes, you are right, this is why config options use_subfolder and subfolder_per_package are already defined in many plugins: use_subfolder and subfolder_per_package in Crypter.py and SimpleCrypter.py gets deleted too but are re-added in every crypter

Local config option use_subfolder overrides the global folder_per_package, so if it is False no folder will be created for this plugin regradless of subfolder_per_package and folder_per_package. If you set use_subfolder to Trueand subfolder_per_package to False, the global folder_per_package config option is used. So if either one of them is True' anduse_subfolderisTrue` also, a folder will be created.

use_subfolder is present only in crypters..

stale[bot] commented 5 years ago

This ticket has been automatically marked as inactive because 90 days have passed since the last comment. It will be closed in 7 days if no further activity occurs. If this issue still requires attention, please leave a comment.

stale[bot] commented 5 years ago

This ticket has been automatically closed. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. Feel free to open a new issue if you deem it appropriate. Don't forget to reference this to the new one. Thanks for your contributions.