search

pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
272 stars 236 forks source link

dirichlet process mixtures for density estimation #101

Open OriolAbril opened 3 years ago

OriolAbril commented 3 years ago

File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/mixture_models/dp_mix.ipynb Reviewers:

The sections below may still be pending. If so, the issue is still available, it simply doesn't have specific guidance yet. Please refer to this overview of updates

Known changes needed

Changes listed in this section should all be done at some point in order to get this notebook to a "Best Practices" state. However, these are probably not enough! Make sure to thoroughly review the notebook and search for other updates.

General updates

*

ArviZ related

*

Changes for discussion

Changes listed in this section are up for discussion, these are ideas on how to improve the notebook but may not have a clear implementation, or fix some know issue only partially.

General updates

*

ArviZ related

*

Notes

Exotic dependencies

Computing requirements

OriolAbril commented 3 years ago

I tried moving from nbsphinx to myst-nb and was unable to do so because the widgets in this notebook are not saved correctly, see https://github.com/jupyter/jupyter-sphinx/blob/master/jupyter_sphinx/ast.py#L607. After manually editing the metadata to remove the widgets completely I was able to build the documentation.

Side note: the DE-MCMC notebooks also have widgets but they are correctly saved are are not a problem.

chiral-carbon commented 3 years ago

can I work on this, since the previous PR only made metadata changes?

OriolAbril commented 3 years ago

Yes, it still needs to be updated. I only fixed the metadata because it was broken and was blocking the switch from nbsphinx to myst-nb

LegrandNico commented 2 years ago

Hi, I would like to update this notebook to pymc v4, is there anything I should know?