pymc-devs / pymc-resources

PyMC educational resources
MIT License
1.96k stars 745 forks source link

Rethinking_2 Chp 6,7,8,9 conversion to PyMC v4 #206

Closed yahrMason closed 2 years ago

yahrMason commented 2 years ago

Thank you for opening a pull request!

Please check our style guide, and also make sure that the notebooks you've modified pass the pre-commit checks. If, for example, you modified notebook1.ipynb and notebook2.ipynb, you could do this by running:

pre-commit run --files notebook1.ipynb notebook2.ipynb

You may need to run it a couple of times before all the checks pass.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

canyon289 commented 2 years ago

Thank you!

EAly commented 2 years ago

Thanks a lot @yahrMason.

I wonder if you already converted chapter 11?

yahrMason commented 2 years ago

@EAly

I have not gotten to chapter 11 yet, I am still working through chapter 10. I can take a look today though, I have picked up a few patterns of syntax that needs to be changed. Perhaps I can turn it around fairly quickly. I will let you know what I uncover.

EAly commented 2 years ago

Thanks a lot @yahrMason , totally appreciate your help!

yahrMason commented 2 years ago

@EAly

Here is the PR for Chp 11 yahrMason:Chp11_v4

EAly commented 2 years ago

Awesome, thanks a lot!

yahrMason commented 2 years ago

@EAly I updated the Chp11 code. I couldn't figure out the new arviz command for hpd (its hdi). I used a normal approximation to get around that and make the plots. I have made the change to hdi. I also made updates to 12 and 13.

EAly commented 2 years ago

Thanks a lot mate.