pymc-devs / pymc-resources

PyMC educational resources
MIT License
1.96k stars 745 forks source link

Rethink2 to pymc v5 #234

Open yahrMason opened 10 months ago

yahrMason commented 10 months ago

Rethinking_2 Conversion to PyMC v5+

I am working on updating the Rethinking_2 notebooks to the current version of PyMC + Pytensor. The changes I am making are:

I made an initial pass through the notebooks and changed all aesara/theano refs to pytensor, and changed the names of all inference data objects to the standard idata convention. Now I need to go through the notebooks and execute them and make sure that they run properly. The following list tracks my progress. Anyone feel free to clone my branch and make edits/updates.

To Do:

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

yahrMason commented 10 months ago

pre-commit is passing locally. Not sure what's causing the issue.

twiecki commented 10 months ago

Amazing effort!

twiecki commented 10 months ago

The pre-commit looks to be a version problem maybe.

twiecki commented 10 months ago

@yahrMason Can you rebase? should fix pre-commit issues.

yahrMason commented 10 months ago

@twiecki ah yep, that solved it. Thanks for that.

twiecki commented 10 months ago

I think @cluhmann had started on a conversion as well, so maybe he can take a look.

yahrMason commented 10 months ago

This will also close #192 and #225