search

pymc-labs / pymc-marketing

Bayesian marketing toolbox in PyMC. Media Mix (MMM), customer lifetime value (CLV), buy-till-you-die (BTYD) models and more.
https://www.pymc-marketing.io/
Apache License 2.0
715 stars 201 forks source link

Fix budget allocation plot in case study #1216

Closed juanitorduz closed 1 week ago

juanitorduz commented 1 week ago

Closes https://github.com/pymc-labs/pymc-marketing/issues/1176

📚 Documentation preview 📚: https://pymc-marketing--1216.org.readthedocs.build/en/1216/

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 1 week ago

View / edit / reply to this conversation on ReviewNB

cluhmann commented on 2024-11-20T20:05:31Z ----------------------------------------------------------------

The alpha=0.7 isn't used in the plots above. Any reason to do it here?


juanitorduz commented on 2024-11-20T20:11:42Z ----------------------------------------------------------------

Good catch! No reason. I removed it.

review-notebook-app[bot] commented 1 week ago

View / edit / reply to this conversation on ReviewNB

cluhmann commented on 2024-11-20T20:05:31Z ----------------------------------------------------------------

Line #2.    fig.suptitle("Response vs spent per channel", fontsize=16);

"spent" should be "Spend"


_juanitorduz commented on 2024-11-20T20:11:50Z_ ----------------------------------------------------------------

Thanks!

juanitorduz commented 1 week ago

Good catch! No reason. I removed it.

View entire conversation on ReviewNB

juanitorduz commented 1 week ago

Thanks!

View entire conversation on ReviewNB

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.