search

pynbody / tangos

The Agile Numerical Galaxy Organisation System
BSD 3-Clause "New" or "Revised" License
19 stars 13 forks source link

Allow inclusion criterion to return None as well as True/False #211

Closed apontzen closed 2 years ago

Martin-Rey commented 2 years ago

Hi @apontzen

I have also run into the same issue with the inclusion criterion than originally reported by @tobibu. This PR also solves it for me, should we merge it in?

apontzen commented 2 years ago

Yes, unfortunately however this fix masks a deeper problem which is that if you gather a property which is some places stored as an integer and other places as a float, some of the data returned will be missing. (That is the origin of the Nones, at least in @tobibu's case)

That would be extremely complicated to fix without degrading performance, so I should post it as a separate issue.