search

pyocd / cmsis-pack-manager

A Rust and Python module for handling CMSIS Pack files
Apache License 2.0
25 stars 33 forks source link

HTTP response codes are not checked #162

Open flit opened 3 years ago

flit commented 3 years ago

Excluding status codes handled automatically by the reqwest crate, HTTP status code are not checked by CPM. Most importantly, this includes 4xx error responses like 404 Not Found. Whatever data the server sends in the response body is still saved to disk.

The location where the response status needs to be checked is here: https://github.com/pyocd/cmsis-pack-manager/blob/7afc42405da2da525c756b1b5f23be478575ca9c/rust/cmsis-pack/src/update/download.rs#L156

mbrossard commented 1 year ago

Should we close this after #199 was merged?