search

pypa / pyproject-metadata

PEP 621 metadata parsing
https://pep621.readthedocs.io
MIT License
37 stars 17 forks source link

Do not consider `version` dynamic when writing RFC 822 metadata if it is set #5

Closed FFY00 closed 2 years ago

FFY00 commented 3 years ago

We allow users to change the version attribute, but we still error out when generating RFC 822 metadata if it is set as dynamic. This should be allowed, if version (https://github.com/FFY00/python-pep621/blob/ed6aecfff8b8102236616a783dc2695f7e4afb14/pep621.py#L178) is set, we should not error out.

https://github.com/FFY00/python-pep621/blob/ed6aecfff8b8102236616a783dc2695f7e4afb14/pep621.py#L285-L288

FFY00 commented 3 years ago

Actually, we can just remove it from that list, as we are already requiring it above.

https://github.com/FFY00/python-pep621/blob/ed6aecfff8b8102236616a783dc2695f7e4afb14/pep621.py#L249-L250

pratham-bhatnagar commented 3 years ago

hey @FFY00 can I work on this issue?