Open bhrutledge opened 4 years ago
Do you have a specific set of files in mind from the above list per PR, so that the effort spend in both writing/rewriting them while reviewing them is reduced?
@deveshks are you looking for guidance about which files to address in a PR? I think the most important aspects are going to be twine/package.py
twine/repository.py
and twine/settings.py
as those are documented as part of our public API and will need extreme care and caution and may lead to a lot of bikeshedding. The twine/commands/*.py
files are probably going to lead to less discussion. Does that help?
The
twine/commands/*.py
files are probably going to lead to less discussion. Does that help?
Thanks for the info, I will probably start with these first.
I'll start working on this issue.
Any PRs for this issue should remove the relevant per-file-ignores
entry in https://github.com/pypa/twine/blob/main/.flake8.
I recommend doing these in small batches, and reviewing the patterns already in use for the existing docstrings. I don't yet have a style guide in mind (beyond what's enforced by flake8-docstrings); maybe that will emerge as part of this work.
Count per error code:
Count per file: