When querying parameters, they should always provide a unit, even if no unit is present

pyro-kinetics / pyrokinetics

Python library to run and analyse gyrokinetics simulations

https://pyrokinetics.readthedocs.io/en/latest/#

GNU Lesser General Public License v3.0

25 stars 6 forks source link

When querying parameters, they should always provide a unit, even if no unit is present #308

Closed whornsby82 closed 7 months ago

whornsby82 commented 8 months ago

When querying parameters, the return is sometimes and xarray Quantity (e.g local_species['ion1'].inverse_lt gives, 5.166073892153321 / lref_minor_radius) and sometimes just a number (e.g q, s_hat). This should be consolidated to a single type of return to make automation cleaner

bpatel2107 commented 7 months ago

This is done now so closing. Just a note, when setting a variable if a unit is not specified then it will maintain the same unit.