search

pyrollo / late

Library Adding Temporary Effects to Minetest
GNU Lesser General Public License v2.1
5 stars 2 forks source link

Support player_monoids #2

Open tacotexmex opened 6 years ago

tacotexmex commented 6 years ago

Instead of

Awful hack for integration with other mods dealing with player physics

why not just add in support for player_monoids?

pyrollo commented 6 years ago

Hi, Fisrt, because LATE could be used without player_monoids, and then because player_monoids lacks support of mob effects and world effects.

I'm really thinking about using player_monoids but it would almost duplicate all player impacts code.

Another idea would be to develop a monoids mod, for players, mobs, world, and others (?) and make player_monoids use that monoids mod only for players.

Then LATE could use monoids (don't forget LATE is about effects on anything, not only players).

There is still a lot of work to find a smart architecture for effects and monoids.

tacotexmex commented 6 years ago

I'm really thinking about using player_monoids but it would almost duplicate all player impacts code.

Are you sure it would have to be that complex? Take a look at my PR for adding monoidal support in playerplus: https://notabug.org/TenPlus1/playerplus/commit/87b6b96514c1ef90b8d00105f1cf233cacf84aeb

tacotexmex commented 6 years ago

Now that I’ve succeded in writing a couple of reimplementations i LATE for various features such as sprinting, I suddenly don’t feel the same urgency for player_monoids. 🙂