pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
496 stars 59 forks source link

TST: update for changes in GEOS #638

Closed martinfleis closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.1%. Comparing base (4037c70) to head (105ceee). Report is 86 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/momepy/pull/638/graphs/tree.svg?width=650&height=150&src=pr&token=VNn0WR5JWT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/momepy/pull/638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #638 +/- ## ======================================= + Coverage 97.4% 98.1% +0.8% ======================================= Files 26 38 +12 Lines 4328 6203 +1875 ======================================= + Hits 4214 6088 +1874 - Misses 114 115 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/pysal/momepy/pull/638?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [momepy/functional/\_dimension.py](https://app.codecov.io/gh/pysal/momepy/pull/638?src=pr&el=tree&filepath=momepy%2Ffunctional%2F_dimension.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvX2RpbWVuc2lvbi5weQ==) | `100.0% <ø> (ø)` | | | [momepy/functional/\_distribution.py](https://app.codecov.io/gh/pysal/momepy/pull/638?src=pr&el=tree&filepath=momepy%2Ffunctional%2F_distribution.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvX2Rpc3RyaWJ1dGlvbi5weQ==) | `100.0% <ø> (ø)` | | | [momepy/functional/\_shape.py](https://app.codecov.io/gh/pysal/momepy/pull/638?src=pr&el=tree&filepath=momepy%2Ffunctional%2F_shape.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvX3NoYXBlLnB5) | `99.1% <ø> (ø)` | | | [momepy/functional/tests/conftest.py](https://app.codecov.io/gh/pysal/momepy/pull/638?src=pr&el=tree&filepath=momepy%2Ffunctional%2Ftests%2Fconftest.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvY29uZnRlc3QucHk=) | `100.0% <100.0%> (ø)` | | | [momepy/functional/tests/test\_distribution.py](https://app.codecov.io/gh/pysal/momepy/pull/638?src=pr&el=tree&filepath=momepy%2Ffunctional%2Ftests%2Ftest_distribution.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvdGVzdF9kaXN0cmlidXRpb24ucHk=) | `100.0% <100.0%> (ø)` | | | [momepy/functional/tests/test\_diversity.py](https://app.codecov.io/gh/pysal/momepy/pull/638?src=pr&el=tree&filepath=momepy%2Ffunctional%2Ftests%2Ftest_diversity.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvdGVzdF9kaXZlcnNpdHkucHk=) | `100.0% <ø> (ø)` | | | [momepy/functional/tests/test\_shape.py](https://app.codecov.io/gh/pysal/momepy/pull/638?src=pr&el=tree&filepath=momepy%2Ffunctional%2Ftests%2Ftest_shape.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvdGVzdF9zaGFwZS5weQ==) | `100.0% <100.0%> (ø)` | | | [momepy/tests/test\_distribution.py](https://app.codecov.io/gh/pysal/momepy/pull/638?src=pr&el=tree&filepath=momepy%2Ftests%2Ftest_distribution.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L3Rlc3RzL3Rlc3RfZGlzdHJpYnV0aW9uLnB5) | `100.0% <100.0%> (ø)` | |
martinfleis commented 4 months ago

The remaining failure is weird and unrelated.

jGaboardi commented 4 months ago

Ready for review?

martinfleis commented 4 months ago

As soon as it stops failing :D

martinfleis commented 4 months ago

Ready for review?

Now it is.