pysat / pysatSpaceWeather

pysat support for space weather indices and data sets

BSD 3-Clause "New" or "Revised" License

7 stars 5 forks source link

pysat RC 3.2.0 fixes #135

Closed aburrell closed 9 months ago

aburrell commented 9 months ago

Description

Remove unneeded kwargs from the instrument instantiation.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran unit tests.

Test Configuration

Operating system: OS X Big Sur
Version number: Python 3.9
Any details about your local setup that are relevant

Checklist:

[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the release checklist on the pysat wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

aburrell commented 9 months ago

See also: https://github.com/pysat/pysatSpaceWeather/actions/runs/7066009749

aburrell commented 9 months ago

Reduction in coverage consistent with change in lines.

jklenzing commented 9 months ago

I've been adding the new coveralls lines in the pysat_rc.yml file too