search

pytest-dev / pytest-asyncio

Asyncio support for pytest
https://pytest-asyncio.readthedocs.io
Apache License 2.0
1.43k stars 152 forks source link

Address invisible hidden files in artifact upload action #941

Closed seifertm closed 2 months ago

seifertm commented 2 months ago

Coverage writes reports to ".coverage" by default. The GitHub action "upload-artifact" no longer includes hidden files by default. This patch changes the coverage file name to a non-hidden file path.

This fixes the failing CI pipeline for pull requests.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.10%. Comparing base (fb5422f) to head (cd06de6). Report is 20 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #941 +/- ## ========================================== - Coverage 91.30% 91.10% -0.20% ========================================== Files 2 2 Lines 506 506 Branches 98 98 ========================================== - Hits 462 461 -1 - Misses 26 27 +1 Partials 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tinche commented 2 months ago

Nb: you could have also reenabled hidden file upload in the action with a flag

seifertm commented 2 months ago

@Tinche Thanks for the review!

Before this PR, each tox environment created its own coverage file in the project root directory. They don't get overwritten either, so the developer has to clean up the files manually every now and then. I found this a bit annoying.

I considered the include-hidden-files option for actions/upload-artifact, but I saw this as a chance to group the coverage files for each tox environment into a single folder to avoid messing up the file explorer for devs :)