Closed Pierre-Sassoulas closed 2 days ago
Thanks for the review @BeyondEvil ! I did not manage to install locally yet (absolute path error I don't understand). Planning to work on this in the next few days and hopefully be able to reproduce the CI fail locally if adding setuptools doesn't work.
Thanks for the review @BeyondEvil ! I did not manage to install locally yet (absolute path error I don't understand). Planning to work on this in the next few days and hopefully be able to reproduce the CI fail locally if adding setuptools doesn't work.
Ugh... windows builds are always sooo slow.
Anyway, I think it's fixed.
Re-add the devel
stuff and I think we're good to merge. 👍
Thanks for the PR! ❤️ 🙏
Nice ! Will do. I plan to merge all the dependabot one next, there's a bunch of pending cve warning that stressed me out :D
Thank you for fixing the pipeline, I had a hard time setting up the dev env locally to troubleshoot !
Most errors are related to
pkg_resources
which I guess is entirely removed in 3.12.However, the code:
We shouldn't hit.
So something is causing an attribute error here: https://github.com/pytest-dev/pytest-html/blob/master/testing/test_unit.py#L22
EDIT: Just realized we can just remove that code since we've dropped support for < 3.9. 🤷♂️