assoc() no longer raises a deprecation warning since commit 22ae8473fb88d6e585b05c709e81e1a46398a649 but the with pytest.deprecated_call(): in that test was not removed then (in contrast with other test cases).
Maybe this got unnoticed due to a pytest bug?
In any case, using pytest 8+ (and keeping deprecated_call()) shows that no warning is raised and the test fails.
Removing the upper bound on pytest in dev dependencies as tests now pass with pytest 8.0.
Fix #1233.
Pull Request Check List
[x] Do not open pull requests from your main branch – use a separate branch!
There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
This is not a pre-requisite for your your pull request to be accepted, but you have been warned.
[x] Added tests for changed code.
Our CI fails if coverage is not 100%.
[x] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
[x] ...and used in the stub test file tests/typing_example.py.
[x] If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.
[x] Updated documentation for changed code.
[x] New functions/classes have to be added to docs/api.rst by hand.
[x] Changes to the signature of @attr.s() have to be added by hand too.
[ x Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecateddirectives.
The next version is the second number in the current release + 1.
The first number represents the current year.
So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
If the next version is the first in the new year, it'll be 23.1.0.
[x] Documentation in .rst and .md files is written using semantic newlines.
[x] Changes (and possible deprecations) have news fragments in changelog.d.
Summary
assoc()no longer raises a deprecation warning since commit 22ae8473fb88d6e585b05c709e81e1a46398a649 but thewith pytest.deprecated_call():in that test was not removed then (in contrast with other test cases).Maybe this got unnoticed due to a pytest bug? In any case, using pytest 8+ (and keeping deprecated_call()) shows that no warning is raised and the test fails.
Removing the upper bound on pytest in dev dependencies as tests now pass with pytest 8.0.
Fix #1233.
Pull Request Check List
mainbranch – use a separate branch!.pyi).tests/typing_example.py.attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives. The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0. If the next version is the first in the new year, it'll be 23.1.0..rstand.mdfiles is written using semantic newlines.changelog.d.