search

python-babel / babel

The official repository for Babel, the Python Internationalization Library
http://babel.pocoo.org/
BSD 3-Clause "New" or "Revised" License
1.29k stars 432 forks source link

Fix: Unexpected behaviour: parse_numbers() doesn't handle space as a grouping symbol, however, parse_decimal() does #1061 #1062

Open sebas-inf opened 5 months ago

sebas-inf commented 5 months ago

Cleaned the string to ensure that it still works if there is a non-breakable space, \xa0, in the number and separed the logic so that it is easeir to understand.

sebas-inf commented 5 months ago

You've committed and pushed your entire .venv – please clean that up first.

Should I just push the file I changed or everything except the .venv?

akx commented 5 months ago

Should I just push the file I changed or everything except the .venv?

Your commit(s) should only have relevant changes.

sebas-inf commented 5 months ago

Should I just push the file I changed or everything except the .venv?

Your commit(s) should only have relevant changes.

Ok, I will push the file with the fix only then.

akx commented 5 months ago

You still have 755 files in this pull request. You'll probably need to git reset 40e60a1f6cf178d9f57fcc14f157ea1b2ab77361 (the current master), then carefully git add only the changes you want, git commit them, and git push --force-with-lease them to your repository.

sebas-inf commented 5 months ago

You still have 755 files in this pull request. You'll probably need to git reset 40e60a1f6cf178d9f57fcc14f157ea1b2ab77361 (the current master), then carefully git add only the changes you want, git commit them, and git push --force-with-lease them to your repository.

should i do all of this within the terminal in vscode where i was working?

akx commented 5 months ago

should i do all of this within the terminal in vscode where i was working?

Maybe. I don't use Visual Studio Code much. Visual Studio Code might have other tools for backing out commits.

sebas-inf commented 5 months ago

should i do all of this within the terminal in vscode where i was working?

Maybe. I don't use Visual Studio Code much. Visual Studio Code might have other tools for backing out commits.

It worked, I made it so i only pushed the numbers.py file.

akx commented 2 months ago

This will require rebasing, and there are still unresolved comments.