python-eel / Eel

A little Python library for making simple Electron-like HTML/JS GUI apps

MIT License

6.5k stars 592 forks source link

Fix WebSocket import error for Python 3.12 compatibility #725

Closed philipdp123 closed 4 months ago

philipdp123 commented 9 months ago

This pull request addresses an issue encountered specifically in Python 3.12 related to importing the WebSocket extension in Bottle applications. The error arises due to the absence of the bottle.ext.websocket

Additionally I added tox configurations for Python 3.11 and Python 3.12

This PR should also resolve the following issues:

723

philipdp123 commented 9 months ago

The solution should also be backwards compatible with other supported versions of python

selltool commented 8 months ago

It verry good

philipdp123 commented 4 months ago

@samuelhwilliams Can you please have a look at pulling this in for 3.12 support

samuelhwilliams commented 4 months ago

Thanks for the nudge and sorry for the delay. This looks good - will merge.

philipdp123 commented 4 months ago

Thanks Samuel!