search

python-hydro / pyro2

A framework for hydrodynamics explorations and prototyping
https://python-hydro.github.io/pyro2
BSD 3-Clause "New" or "Revised" License
305 stars 124 forks source link

HSE boundary conditions don't work with fv4 #301

Open zingale opened 1 day ago

zingale commented 1 day ago

Not sure why, but they seem to cause the Rayleigh-Taylor to life up as time evolves.

zingale commented 1 day ago

note that it works just fine with compressible_rk using RK4 integration, so the issue seems to be the spatial reconstruction, not the temporal evolution. I suspect that the problem is that the 4th order stencils don't work because we are passing in cell-averages and then we need to do HSE integration on the cell averages, but we are treating them like cell-centers.

zingale commented 1 day ago

it would be better to just add the one-sided stencils to do a better job with reflecting BCs with 4th order, see #244

zingale commented 1 day ago

rt

zingale commented 1 day ago

that's an example ^ left is HSE BCs and right is reflect