python-restx / flask-restx

Fork of Flask-RESTPlus: Fully featured framework for fast, easy and documented API development with Flask

https://flask-restx.readthedocs.io/en/latest/

Other

2.14k stars 333 forks source link

Introduce temporary package version restrictions #579

Closed peter-doggart closed 10 months ago

peter-doggart commented 10 months ago

This PR introduces a temporary restriction on flask, werkzeug and jsonschema packages until we can get everything updated.

It was my intention to temporarily point the pytest-flask installation to a fork that included the 3.0.0 fixes until they are merged upstream. However, the pipeline installs via setuptools and the pip() function in setup.py strips out pip git checkout links.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7ce0ef8) 96.45% compared to head (f323b67) 96.45%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #579 +/- ## ======================================= Coverage 96.45% 96.45% ======================================= Files 20 20 Lines 2733 2733 ======================================= Hits 2636 2636 Misses 97 97 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

peter-doggart commented 10 months ago

Bench test fails because install is broken on master, so that can safely be ignored!

brianpaden289 commented 10 months ago

Is there an issue with jsonschema==4.19.1? This restriction is causing conflicts in our environment because other tools require 4.19.1.

peter-doggart commented 10 months ago

@brianpaden289 There is an open issue and PR for jsonschema related stuff. It looks like part of the package we use either has been removed or is going to be removed. I just haven't had a chance to look at it yet unfortunately!

See https://github.com/python-restx/flask-restx/pull/560

foarsitter commented 10 months ago

560 is about a deprecation warning https://github.com/python-restx/flask-restx/issues/553