python-trio / async_generator

Making it easy to write async iterators in Python 3.5

Other

95 stars 23 forks source link

Correct syntax highlighting in README #18

Closed touilleMan closed 6 years ago

touilleMan commented 6 years ago

It seems Github no longer recognizes python3 in rst's code-block:: xxx tags. Beside Github's python highlighting seems to accept Python3 keywords like await/async.

codecov[bot] commented 6 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         776    776           
  Branches       59     59           
=====================================
  Hits          776    776

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17521f8...541f92b. Read the comment docs.

touilleMan commented 6 years ago

(btw I just realized doing this edit from the Github website made me create a branch in the main repo instead of forking and working on my own... sorry for that 😢 )

njsmith commented 6 years ago

See #12 – Github never recognized python3, but pypi requires it. Github merged my patch to start accepting python3 like 2 months ago, but I guess they must still not have deployed it...? idk

touilleMan commented 6 years ago

but pypi requires it

Do you know if it requires it on the old pypi website, the new one or on both ?

Anyway, feel free to close this PR (and remove the related branch). I can do it myself if you prefer

njsmith commented 6 years ago

.. code-block:: python3 seems to be working on Github now!