search

python-trio / async_generator

Making it easy to write async iterators in Python 3.5
Other
95 stars 23 forks source link

[appveyor] Fix coverage by installing sdist version #7

Closed pquentin closed 6 years ago

pquentin commented 6 years ago

This is closer to what we do in Travis. However, async_generator.__file__ was not pointing to the correct path (shown by pip show -f async_generator), so I decided to build it manually. This is probably quite brittle, but at least it currently works.

Fixes #6.

codecov[bot] commented 6 years ago

Codecov Report

Merging #7 into master will decrease coverage by 8.08%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage     100%   91.91%   -8.09%     
==========================================
  Files           5        5              
  Lines         581      581              
  Branches       48       48              
==========================================
- Hits          581      534      -47     
- Misses          0       47      +47
Impacted Files Coverage Δ
async_generator/__init__.py 0% <0%> (-100%) :arrow_down:
async_generator/util.py 42.85% <0%> (-57.15%) :arrow_down:
async_generator/impl.py 74.17% <0%> (-25.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e303e07...c7909c9. Read the comment docs.

pquentin commented 6 years ago

I'm not sure why the coverage is lower. And it looks like there's work left for the codecov integration in Appveyor.

pquentin commented 6 years ago

Closing as I'm not sure this improves anything. If someone else comes along maybe they'll be able to continue that work.