Closed A5rocks closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.62%. Comparing base (
8f2c08c
) to head (0cdb392
). Report is 3 commits behind head on main.
🚨 Try these New Features:
@A5rocks can we get a test for this? Eg set the expected architecture somewhere and then check the architectures of sys.executable are a superset
@A5rocks can we get a test for this? Eg set the expected architecture somewhere and then check the architectures of sys.executable are a superset
Yeah that's a good idea. Maybe having a dictionary + indexing into that.
Actually that wouldn't work would it? It's not like we ever had an x86 pypy so the test wouldn't catch anything.
It would catch say cpython dropping x86 support or running x86 cpython on arm macos
It would catch say cpython dropping x86 support
I don't think it would, actually. Not if the test looks something like <executable architecture> in [<list of architectures>]
, and I can't think of a form that would catch that. Maybe I'm just not thinking of the same test as you.
(I guess the second would work if we did <executable architecture> in {...}[<platform>]
but presumably it would fail to execute to begin with? I don't actually know what Rosetta is or whether that would kick in.)
It should be
assert any(arch == os.environ["EXPECTED_ARCH"] for arch in architectures(sys.executable))
Fixes https://github.com/python-trio/trio/issues/3129
This is because "x86" pypy is just setup-python installing x64 pypy.