search

python-visualization / folium

Python Data. Leaflet.js Maps.
https://python-visualization.github.io/folium/
MIT License
6.93k stars 2.23k forks source link

Folium loads two versions of bootstrap #1908

Closed bopjesvla closed 7 months ago

bopjesvla commented 8 months ago

Describe the bug

Folium currently loads two versions of bootstrap:

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@5.2.2/dist/css/bootstrap.min.css"/>
<link rel="stylesheet" href="https://netdna.bootstrapcdn.com/bootstrap/3.0.0/css/bootstrap.min.css"/>

To Reproduce

The first Folium iframe on https://python-visualization.github.io/folium/latest/getting_started.html contains the above snippet.

Conengmo commented 7 months ago

That's correct, we require Bootstrap 3 to show Glyphicons. See https://github.com/python-visualization/folium/pull/1650.

But I did just notice in https://stackoverflow.com/a/18225474/4082914 they also list a css just for Glyphicons. It seems to work as well. Not sure why we didn't include that in https://github.com/python-visualization/folium/pull/1650. I'll open a PR.