python-visualization / folium

Python Data. Leaflet.js Maps.
https://python-visualization.github.io/folium/
MIT License
6.93k stars 2.23k forks source link

Add `Leaflet.encoded` plugin: Enable creating PolyLine and Polygon from encoded string #1928

Closed achieveordie closed 6 months ago

achieveordie commented 7 months ago

Fixes #1886

FYI @hansthen

achieveordie commented 7 months ago

In hindsight, I'm also considering adding the second functionality the original author provides - Polygon.fromEncoded(). They will be in the same plugin file (renamed from polyline_encoded to encoded) but have separate test/doc files.

hansthen commented 7 months ago

In hindsight, I'm also considering adding the second functionality the original author provides - Polygon.fromEncoded(). They will be in the same plugin file (renamed from polyline_encoded to encoded) but have separate test/doc files.

Do you want to include this in this PR? If so, go ahead, but you can also do it in a later PR.

achieveordie commented 7 months ago

done @hansthen :)

achieveordie commented 6 months ago

How long before this can be merged? I'd like to use the 'official' feature :)

achieveordie commented 6 months ago

@Conengmo I appreciate your input on the error. It was an oversight on my end. This PR should be good to go.