Open serhiy-storchaka opened 1 month ago
I think a leading dot is a good approach to get a name that doesn't conflict with user-defined names: it always works and it's already what we do in a few other places in the compiler pipeline (e.g., PEP 695 annotation scopes can have a compiler-created local variable called .type_params
).
was solved in other way
Yes and I dislike that way although I couldn't come up with something else... It's a bit too fragile IMO =/
I'm actually happy with both proposals:
.type == TYPE_GENERATOR_EXPRESSION
without exposing any name. The issue is that you introduce more types but I'm not sure whether something else needs to be changed in symtable.c
.genexpr
to be a hard keyword (or any other kind of name, like maybe __Py_genexpr
but I don't think we gain anything here...). For brackets, I think it's already the case for the repr()
but not in the symbol table itself.
Feature or enhancement
Every symbol table has type and name. The name of the symbol table that corresponds a class or a function is the same as the name of the corresponding class or function. But there are special symbol tables of type function for lambdas and generator expressions (there were also symbol tables for comprehensions, but they are no longer used). For lambdas. the name "lambda" does not conflict with other function names, because it is a reserved word. But for general expressions, the name "genexpr" can conflict with local function "genexpr" (see #119698). It is possible to distinguish the symbol table corresponding to a generator expression by looking in the list of its parameters, but this is not so convenient.
I propose to make the difference more clear:
Or use names which cannot be confused with any function name:
lambda
. But I do not know good variant for generator expression.gen-expr
.<genexpr>
and<lambda>
..genexpr
.Names of symbol tables of other types like
top
and__annotations__
can also be changed for uniformity and to avoid possible future conflicts.The original issue #119698 was solved in other way, so there is no urge for such change. This is just a wild idea.