python / release-tools

Scripts for making (C)Python releases
39 stars 33 forks source link

Add SBOMs generation for Windows artifacts #100

Closed sethmlarson closed 7 months ago

sethmlarson commented 8 months ago

Moved the branch to this repo to allow testing before merging in Azure Pipelines. Requires https://github.com/python/cpython/pull/115789 to be checked in to work.

zooba commented 7 months ago

New test build running at https://dev.azure.com/Python/cpython/_build/results?buildId=152746&view=results

sethmlarson commented 7 months ago

@zooba Thanks for the run, the joys of developing CI workflow definitions continues :)

zooba commented 7 months ago

Looking at the most recent failure, it seems you probably want $(Build.SourceBranchName) rather than $(Build.SourceBranch). (I really wish Git had a better way to just clone a single known commit, but apparently not...)

sethmlarson commented 7 months ago

The SBOM artifacts are getting uploaded into the sbom artifact name as expected: https://dev.azure.com/Python/cpython/_build/results?buildId=152774&view=artifacts&pathAsName=false&type=publishedArtifacts

I downloaded them all and gave them a look, they contain the components I expect and SBOM tooling accepts them. This PR can be ready to go as-is or we could also add the "upload" step in this PR too.