search

python / typing_extensions

Backported and experimental type hints for Python
Other
445 stars 109 forks source link

Third-party tests failed on Tue Nov 12 2024 #503

Closed github-actions[bot] closed 1 week ago

github-actions[bot] commented 1 week ago

Full history of runs listed here: https://github.com/python/typing_extensions/actions/workflows/third_party.yml

brianschubert commented 1 week ago

pydantic tests are failing again:

  uv sync --group testing --group dev
  shell: /usr/bin/bash -e {0}
  env:
    PIP_DISABLE_PIP_VERSION_CHECK: 1
    FORCE_COLOR: 1
    UV_CACHE_DIR: /home/runner/work/_temp/setup-uv-cache
error: Group `testing` is not defined in the project's `dependency-group` table
Error: Process completed with exit code 2.

Looks like this is due to https://github.com/pydantic/pydantic/pull/10815, which changed the dependency group definitions.

Viicos commented 1 week ago

Sorry again for the inconvenience, I'll fix this one.

Viicos commented 1 week ago

Alternatively, maybe it's best to remove the pydantic third-party test, as we already test on typing-extensions main on our end?

AlexWaygood commented 1 week ago

I think it's pretty useful for us to have an immediate notification when we've broken pydantic. "We will break pydantic by cutting a release" is definitely bad enough to block a release for us, IMO -- the last time I did that it wasn't so fun 😆

We knew there was a risk of this workflow occasionally breaking due to things like this when we added the workflow. Unless you expect these breakages to be very common, rather than just a few teething issues while you migrate to uv, I think I'd probably vote to stick with things as they are. typing_extensions is important enough in the ecosystem that a little bit more maintenance burden for us is OK if it avoids us breaking the world, I think.

I guess I'd also be okay with a workflow where you immediately open an issue with us if your nightly tests with the typing_extensions main branch fail! I just really really don't want us cutting a release that breaks you guys without us being aware of it first. Even if it's a problem at your end, we'd almost certainly want to wait until you guys fixed it before we cut a new release 😄

Viicos commented 1 week ago

Sounds good, in that case, we'll try to avoid changing too many things in our CI. If you ever get new pydantic failures, do not hesitate to assign/ping me and I'll be available to provide a fix if possible. I'm currently working on tidying out our CI, and will update the third party test here accordingly.