search

pythondave / th-frontend

0 stars 0 forks source link

User story: As a signed-in user, I can search and filter jobs #35

Open pythondave opened 11 years ago

pythondave commented 11 years ago

Hi guys,

This is the user story I'm currently focusing on.

@villarin - what structure would be best for you? My instinct is to add a new SPA to the th-frontend spa folder.

With reference to the current structure (replicated below), something like the following...

th-frontend
    scaffolding - stuff related to construction, mainly discarded on release
    shared - stuff which is not necessarily specific to a single spa
    spa - single page applications
        admin - stuff which any admin user can access
            dashboard - the 'admin dashboard' spa - various bits of functionality
        school - stuff which any school user can access
            dashboard - the 'school dashboard' spa - various bits of functionality
        logged-in - stuff which any logged-in user can access <---- PROPOSED NEW FOLDER HERE
            jobs - functionality relating to jobs <---- PROPOSED NEW SPA HERE
    style - shared styles, should probably be moved to 'shared' at some point

So 'logged-in' and 'jobs' are the proposals.

What do you think? Thoughts and other proposals welcome...

Cheers, Ryan

villarin commented 11 years ago

Hi Ryan

I think is good we keep the same structure - particularly using a common root folder for all the client side features (like th-frontend in the prototype).

The refactoring in #34 will not be applied this year but we will certainly do so next year - so it is great to keep it organised that way.

From the below additions - I am Ok with "jobs" but don't understand why we need "logged-in" - as this feature requires authentication in advance and we already handle that via the 401 handler.

Otto

From: Ryan Randall [mailto:notifications@github.com] Sent: 11 November 2013 17:04 To: pythondave/th-frontend Cc: villarin Subject: [th-frontend] User story: As a signed-in user, I can search and filter jobs (#35)

Hi guys,

This is the user story I'm currently focusing on.

@villarin https://github.com/villarin - what structure would be best for you? My instinct is to add a new SPA to the th-frontend spa folder.

With reference to the current structure (replicated below), something like the following...

th-frontend scaffolding - stuff related to construction, mainly discarded on release shared - stuff which is not necessarily specific to a single spa spa - single page applications admin - stuff which any admin user can access dashboard - the 'admin dashboard' spa - various bits of functionality school - stuff which any school user can access dashboard - the 'school dashboard' spa - various bits of functionality logged-in - stuff which any logged-in user can access <---- PROPOSED NEW FOLDER HERE jobs - functionality relating to jobs <---- PROPOSED NEW SPA HERE style - shared styles, should probably be moved to 'shared' at some point

So 'logged-in' and 'jobs' are the proposals.

What do you think? Thoughts and other proposals welcome...

Cheers, Ryan

Reply to this email directly or view it on GitHub https://github.com/pythondave/th-frontend/issues/35 . https://github.com/notifications/beacon/C6aQ2lOetMBBdndp2ctui7tTY5bdUCGEXJn G-ir-qZDONci1gZtaTRuzyZWEqFPG.gif

pythondave commented 11 years ago

I was just proposing this as a mirror of the admin and school folders.

The admin folder contains SPAs which any admin user can access; the school folder contains SPAs which any school user can access. Where should we put SPAs which any logged-in user can access?

Feel free to propose an alternative which makes sense to you...

villarin commented 11 years ago

Ok I think I get where you are coming from. However the way we use these spas is slightly different - for example an admin can generally access all these areas i.e. spas/school spas/admin/ and others.

So I was under the impression that those higher level sections identified a functional area within the system - i.e. school or admin features.

That is why I thought that jobs or maybe recruitment could work for this particular task.

pythondave commented 11 years ago

Understood.

There are pros to structuring according to the type of user, and there are pros to structuring according to the type of thing being viewed.

I'm still not sure what the best approach is for us in general - or whether a mix of approaches is best.

I don't think there's value thinking about this too much right now, so I'm happy to try to side-step it for the moment.

So, how about the following structure?...

th-frontend
    scaffolding - stuff related to construction, mainly discarded on release
    shared - stuff which is not necessarily specific to a single spa
    spa - single page applications
        admin - stuff which any admin user can access
            dashboard - the 'admin dashboard' spa - various bits of functionality
                jobs - functionality relating to jobs which is only available to admins (added here as a reminder of its existence)
        school - stuff which any school user can access
            dashboard - the 'school dashboard' spa - various bits of functionality
        jobs - jobs spa - functionality relating to jobs which isn't elsewhere <---- PROPOSED NEW SPA HERE
    style - shared styles, should probably be moved to 'shared' at some point

Note that 'admin/dashboard/jobs' exists already. I've explicitly pointed that out above to illustrate the 'conflict' we're side-stepping :)

What do you think? Are you happy to go with this structure?

Cheers, Ryan

villarin commented 11 years ago

Sounds good Ryan!

I can see your point about the naming conflict within sections - However the structure you propose addresses that issue quite well in my opinion.

pythondave commented 11 years ago

Hi guys,

I've done a mockup of the wireframe: http://pythondave.github.io/th-frontend/3/0.1/spas/jobs/default.html#/

It's all style and no substance.

This is a step on from the wireframe because you can see how it will look and behave within the browser (e.g. when you change the browser size, scroll, change zoom etc.). You can check it in different browsers too if you like. You should see that there's nothing fancy here at all.

@alexistoye / @Alex-Teacherhorizons / @villarin - Can each of you confirm that there are no surprises here? Is there anything you think we should consider changing?

Cheers! Ryan

alexistoye commented 11 years ago

Hi Ryan,

This is great work and super speedy too! No surprises I hope!

I have tested in the following:

  1. Ipad (multiple browsers), android phone, chrome, ie 10, firefox & safari - all worked and showed beautifully!
  2. IE8 & IE9 nothing apart from header showed - good old Microsoft! See below for screen shot:

image

A couple of points:

Can we change Type of School to Academic system (eg: American, British, etc) so that it is consistent with the SPPs. I've thought about this quite a bit and whilst Education level would make more sense for most teachers (eg Primary, Middle School) the vast majority of our schools are all the way through so it makes no sense filtering by those. Otherwise, we can take away this filter as not massively important.

In the start date section in grey it would be great if it could say something like "When is the earliest you can start" and only jobs after or 2 months after that show? We wouldn't want only jobs for that exact date to show!

Jobs would only need to show if they are before their expiry date - after this they don't display on the page.

Finally, are we going to cap the number of results shown for speed? It may make sense - whatever number you think makes sense.

I am presuming the pop up box when you click apply and are under 80% hasn't been built yet.

Great great work, can't wait to see it in action!

villarin commented 11 years ago

Hey @pythondave

Thanks for that! Looking good already.

Just noticed the following:

  1. I forgot to include the profile image in the api response samples - so will send you up to date samples tomorrow.
  2. The main container does not show for me on IE8 - looks fine on IE9/10 though.

Otto

pythondave commented 11 years ago

Thanks guys.

I've tried to reply as best I can to all the points below...

Can we change Type of School to Academic system (eg: American, British, etc)

Fine by me. @villarin please note.

In the start date section in grey it would be great if it could say something like "When is the earliest you can start"

I'm not sure I follow. If you're asking to replace the words 'When do you want to start' with 'When is the earliest you can start', then this is of course fine. If not, please elaborate.

In general, I can't say I'm a big fan of the wording in the filters. I just copied what was in the wireframe.

only jobs after or 2 months after that show?

I would be confused as a user if I answered a question which said 'When is the earliest you can start' and then jobs which start 3 months after that were no longer displayed. So perhaps I haven't followed what you're asking. I suggest a call to discuss.

Finally, are we going to cap the number of results shown for speed? It may make sense - whatever number you think makes sense.

This is the plan, yes. I mentioned this in the paging discussion in #36.

I am presuming the pop up box when you click apply and are under 80% hasn't been built yet.

That's correct. It hasn't even been designed yet.

  1. I forgot to include the profile image in the api response samples - so will send you up to date samples tomorrow.

Good point! I missed that too!

IE8

Thanks, I didn't check this. It looks like I won't be able to reuse some of what I've been working on recently (i.e. the dashboards). Several of the third party tools we're using have already dropped support for IE8, so I'll have to find alternatives. All very irritating!

Cheers! Ryan

Alex-Teacherhorizons commented 11 years ago

Looking great!

On Thu, Nov 14, 2013 at 1:02 AM, Ryan Randall notifications@github.comwrote:

Hi guys,

I've done a mockup of the wireframe: http://pythondave.github.io/th-frontend/3/0.1/spas/jobs/default.html#/

It's all style and no substance.

This is a step on from the wireframe because you can see how it will look and behave within the browser (e.g. when you change the browser size, scroll, change zoom etc.). You can check it in different browsers too if you like. You should see that there's nothing fancy here at all.

@alexistoye https://github.com/alexistoye / @Alex-Teacherhorizonshttps://github.com/Alex-Teacherhorizons/ @villarin https://github.com/villarin - Can each of you confirm that there are no surprises here? Is there anything you think we should consider changing?

Cheers! Ryan

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-28417958 .

Alex ReynoldsDirector of Communicationswww.teacherhorizons.com http://www.teacherhorizons.com/+44 7796 511 500 Skype: Alex.teacherhorizons http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfAWatch our video here! http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.teacherhorizons.com/ http://www.linkedin.com/groups/Teacherhorizons-3782926?trk=myg_ugrp_ovr http://goog_21780030/ http://www.facebook.com/teacherhorizons http://goog_21780039/ http://www.twitter.com/teacherhorizons https://plus.google.com/b/101365118875012446063/101365118875012446063/posts http://www.teacherhorizonsblog.com/

alexistoye commented 11 years ago

Hi Ryan,

Agree with all your points.

Perhaps we can discuss them tonight before I leave? Will be up late!

Cheers

Alexis

pythondave commented 11 years ago

@alexistoye - Thanks for the IM chat. All points agreed and understood now.

@villarin

The requirement for the 'start date' filter is to show any job on or after that date. Is that okay with you?

Re the limit (in the absence of paging): shall we make this a variable I pass (set in the config, say), or do you want to agree it now? Can the limit be applied after ordering by 'start date' asc?

Let me know :)

Cheers! Ryan

villarin commented 11 years ago

The requirement for the 'start date' filter is to show any job on or after that date. Is that okay with you?

Yeap that is fine

Re the limit (in the absence of paging): shall we make this a variable I pass (set in the config, say), or do you want to agree it now?

Yes please create as a config variable - and pass it as a parameter in the api call i.e. {filters..., limit: config.pageSize}

Can the limit be applied after ordering by 'start date' asc?

Sure - can implement that way - do we need any other sorting option?

pythondave commented 11 years ago

Fantastic!

do we need any other sorting option?

This is a nice-to-have. As with the paging, my plan is to not think about this until the must-haves are done.

That said, I'm currently reasonably optimistic that I'll have some time spare, so if you feel inclined to add sorting options to the API, it's pretty likely they'll get used in this sprint.

Thanks again! Ryan

villarin commented 11 years ago

Good! Will allow two more parameters in the api method: Sort => numeric 1,2 etc to ident field Sortdirection => 0 or 1 for asc/desc

----- Reply message ----- From: "Ryan Randall" notifications@github.com To: "pythondave/th-frontend" th-frontend@noreply.github.com Cc: "villarin" otto@tbtech.co.uk Subject: [th-frontend] User story: As a signed-in user, I can search and filter jobs (#35) Date: Fri, Nov 15, 2013 00:24 Fantastic!

do we need any other sorting option?

This is a nice-to-have. As with the paging, my plan is to not think about this until the must-haves are done.

That said, I'm currently reasonably optimistic that I'll have some time spare, so if you feel inclined to add sorting options to the API, it's pretty likely they'll get used in this sprint.

Thanks again!

Ryan

— Reply to this email directly or view it on GitHub.

pythondave commented 11 years ago

Hi guys,

I just committed the latest changes for this. You can see them here: http://pythondave.github.io/th-frontend/3/0.1/spas/jobs/default.html#/

Feel free to have a play (there's not much to it!) and feed back any thoughts however you think best.

As usual with the prototypes, you need to treat the data with a pinch of salt.

Note that the type of user (<80% complete teacher or not) is determined randomly whenever a search is done. So sometimes a modal (popup) will open and sometimes a job url will be navigated to - so you can see the behaviour of each.

The only thing I don't need feedback on yet is the date filter - I've not added that yet.

I think I need to look at IE8 again. Before my laptop broke I emulated IE8 in my installed IE10 and got that working. I just opened IE and it seems that IE11 was installed on my laptop yesterday. When I emulate IE8 I get an issue which I don't think was there with the IE10 emulation. I'll investigate this over the next few days.

Cheers! Ryan

alexistoye commented 11 years ago

Hi Ryan,

This looks great - in the process of testing now

@Alex-Teacherhorizons - would you mind reviewing this as it could do with a bit more personality than what I have written below!

Could the pop up please say:

Title: To view full details please complete your profile

The details of all our vacancies are protected.

To view all our current teaching opportunities, please ensure your profile is 80% complete and that you have signed in. It will only take 10 minutes to complete.

Once we have more information about you, we'll be in a much better position to support you in finding your dream job.

Complete my profile (with link to profile edit version)

alexistoye commented 11 years ago

I don't think the curriculum filter is going to work because it is set by the school, not the job. When I select IB DP it shows a load of jobs for IB PYP. @Alex-Teacherhorizons , should we hide that for now?

alexistoye commented 11 years ago

When I selected Middle East in the continent it didn't work - the continent filter doesn't seem to be working actually. I also don't think we can have Middle East as an option as we don't currently have the ability to add a school to the Middle East (it is grouped as part of Asia). We hope to change that one day

pythondave commented 11 years ago

I think perhaps you're not taking the data with a pinch of salt?

On 29 November 2013 13:18, Alexis notifications@github.com wrote:

When I selected Middle East in the continent it didn't work - the continent filter doesn't seem to be working actually. I also don't think we can have Middle East as an option as we don't currently have the ability to add a school to the Middle East (it is grouped as part of Asia). We hope to change that one day

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29515627 .

alexistoye commented 11 years ago

Please expand!!!

pythondave commented 11 years ago

I'll IM you...

On 29 November 2013 13:21, Alexis notifications@github.com wrote:

Please expand!!!

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29515722 .

pythondave commented 11 years ago

Here's the IM summary (correct me if I've missed anything or got anything wrong):

Cheers! Ryan

On 29 November 2013 13:22, Ryan Randall pythondave@gmail.com wrote:

I'll IM you...

On 29 November 2013 13:21, Alexis notifications@github.com wrote:

Please expand!!!

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29515722 .

alexistoye commented 11 years ago

Couldn't have said it better myself!

pythondave commented 11 years ago

Hi guys,

I've just pushed an update with the following:

http://pythondave.github.io/th-frontend/3/0.1/spas/jobs/default.html#/

I'll do my 2 tidying to-do items over the next few days and will do the modal as soon as I have the spec confirmed. Let me know if there's anything else :)

Cheers, Ryan

P.S. You should be aware that my roller-coaster of laptop fun didn't in fact end last Tuesday. After I did the TH update last Wednesday, I needed to sort out my backup processes. A series of events followed which led to me realising the disk was still damaged, and eventually having to rescue and reinstall everything. Yay!

Things are now slowly getting back to normal. Well they better be... if anything else goes wrong any time soon there's a danger I may get slightly angry.

On 29 November 2013 14:06, Alexis notifications@github.com wrote:

Couldn't have said it better myself!

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29517978 .

alexistoye commented 11 years ago

Hi Ryan,

Thanks for persevering!

This looks great. I have cross browser tested it and checked on different screen sizes too - works really well across all these.

@Alex-Teacherhorizons , could you please provide Ryan with the text for the pop ups and then i think we are ready to rumble!

Cheers!

Alexis

Alex-Teacherhorizons commented 11 years ago

Hi Ryan,

Hope you're well - these are looking really great!

Here's the suggested text - think it's pretty simple and clear. Alexi hasn't reviewed yet so could change but not majorly...

Title: Please complete your profile

The details of our opportunities are protected.

To access this information, please sign in [hyperlink] and complete your profile to 80%.

It will take just a few minutes and will open a lifetime of opportunities!

Complete my profile [link to TPEP]

Thanks,

A

On Mon, Dec 2, 2013 at 4:28 PM, Alexis notifications@github.com wrote:

Hi Ryan,

Thanks for persevering!

This looks great. I have cross browser tested it and checked on different screen sizes too - works really well across all these.

@Alex-Teacherhorizons https://github.com/Alex-Teacherhorizons , could you please provide Ryan with the text for the pop ups and then i think we are ready to rumble!

Cheers!

Alexis

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29604075 .

Alex ReynoldsDirector of Communicationswww.teacherhorizons.com http://www.teacherhorizons.com/+44 7796 511 500 Skype: Alex.teacherhorizons http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfAWatch our video here! http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.teacherhorizons.com/ http://www.linkedin.com/groups/Teacherhorizons-3782926?trk=myg_ugrp_ovr http://goog_21780030/ http://www.facebook.com/teacherhorizons http://goog_21780039/ http://www.twitter.com/teacherhorizons https://plus.google.com/b/101365118875012446063/101365118875012446063/posts http://www.teacherhorizonsblog.com/

Alex-Teacherhorizons commented 11 years ago

Hi Ryan,

Here's the pop up text:

Title: Please complete your profile

The details of our opportunities are protected.

To access this information, please sign in [hyperlink] and complete your profile to 80%.

It will take just a few minutes and will open a lifetime of opportunities!

Complete my profile [link to TPEP]

villarin commented 11 years ago

I think the user is logged in at this point - so we may only need the complete profile part on this screen?

pythondave commented 11 years ago

Hi guys,

I've just released a quick/simple 1st draft of the modal. I also realised the start date didn't work with the back/forward buttons, so that's now also done.

http://pythondave.github.io/th-frontend/3/0.1/spas/jobs/default.html#/

@Alex-Teacherhorizons / @alexistoye : what are your thoughts on Otto's point?

@villarin : where can I get/derive the [link to TPEP] value from?

Cheers! Ryan

alexistoye commented 11 years ago

Hi Guys,

Great stuff Ryan, thanks!

Personally, I think it would be great to allow teachers to skim jobs (which now don't have school names) before they sign up.

We now have several ways of getting them to sign up: landing page, contract and jobs tabs of SPPs and searching full job adverts so I think that will suffice. We probably should let them have a little look around. I know I wouldn't want to bother completing a 15 min form if I didn't know what kind of opportunities lay at the end of it, particularly as most people are still having a punt when using us.

If we do this we'd need the sign in option there too.

@villarin and @Alex-Teacherhorizons , what do you make of this? Getting this balance between forcing them to sign up and share their information with dangling a carrot in front of them is a tricky one!

Cheers!

Alexis

Alex-Teacherhorizons commented 11 years ago

I agree with Alexis - we should really show users (of all levels) the value in completing a profile

For that reason, I think everyone should be able to view the job listings (without the school name) and be driven to either sign up or complete their profile when they try and get the things they want.

ie 'if you want our info, you can frickin well give us your's' - a philosophy we can use more and more as we grow.

cheers,

A

Alex-Teacherhorizons commented 11 years ago

Another thought on this BTW, can we make the blue title of each listing (eg Primary KS2 teacher) clickable as well.

If they click on it, the same pop up screen appears - basically another route in...

What do you think @alexistoye?

pythondave commented 11 years ago

I think it should be acknowledged that this is would be a change in the user story.

i.e. it would no longer be "As a signed-in user, I can search and filter jobs" but "As a user (of any type), I can search and filter jobs".

There are no problems with this change from my perspective.

On 3 December 2013 02:21, Alex-Teacherhorizons notifications@github.comwrote:

Another thought on this BTW, can we make the blue title of each listing (eg Primary KS2 teacher) clickable as well.

If they click on it, the same pop up screen appears - basically another route in...

What do you think @alexistoye https://github.com/alexistoye?

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29678189 .

Alex-Teacherhorizons commented 11 years ago

I agree

On Tue, Dec 3, 2013 at 11:12 AM, Ryan Randall notifications@github.comwrote:

I think it should be acknowledged that this is would be a change in the user story.

i.e. it would no longer be "As a signed-in user, I can search and filter jobs" but "As a user (of any type), I can search and filter jobs".

There are no problems with this change from my perspective.

On 3 December 2013 02:21, Alex-Teacherhorizons notifications@github.comwrote:

Another thought on this BTW, can we make the blue title of each listing (eg Primary KS2 teacher) clickable as well.

If they click on it, the same pop up screen appears - basically another route in...

What do you think @alexistoye https://github.com/alexistoye?

— Reply to this email directly or view it on GitHub< https://github.com/pythondave/th-frontend/issues/35#issuecomment-29678189>

.

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29682333 .

Alex ReynoldsDirector of Communicationswww.teacherhorizons.com http://www.teacherhorizons.com/+44 7796 511 500 Skype: Alex.teacherhorizons http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfAWatch our video here! http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.teacherhorizons.com/ http://www.linkedin.com/groups/Teacherhorizons-3782926?trk=myg_ugrp_ovr http://goog_21780030/ http://www.facebook.com/teacherhorizons http://goog_21780039/ http://www.twitter.com/teacherhorizons https://plus.google.com/b/101365118875012446063/101365118875012446063/posts http://www.teacherhorizonsblog.com/

villarin commented 11 years ago

I can see the benefit of this change - However it does affect the specs and implementation of the backend functionality of this feature. Will follow up on a separate thread

alexistoye commented 11 years ago

Cool, I agree with Alex's suggestion if possible.

Just an idea: how about making the whole mini job advert clickable - would make it much more like Google's card system which I like!

Cheers

pythondave commented 11 years ago

Update pushed incorporating a stab at few of these ideas...

http://pythondave.github.io/th-frontend/3/0.1/spas/jobs/default.html#/

@villarin : I need to be able to get/derive: a) the [link to TPEP] value, b) whether or not the user is logged in. How am I best to do that?

Cheers! Ryan

villarin commented 11 years ago

You can use - "/me"

pythondave commented 11 years ago

Can you elaborate?

villarin commented 11 years ago

Href="/me" would do - this will either take the current teacher to the tpep or to the login page if not authenticated

pythondave commented 11 years ago

I see, thanks.

In addition to this, I'd like to know whether or not they're logged in, so I can show/hide the login wording accordingly. Is that possible? How am I best to get/derive that?

Thanks again, Ryan

On 3 December 2013 15:25, villarin notifications@github.com wrote:

Href="/me" would do - this will either take the current teacher to the tpep or to the login page if not authenticated

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29718649 .

villarin commented 11 years ago

I think the api method for job listings returns an attribute "usertype"(not 100% sure now but will confirm when I am home) That attribute currently returns whether the user has an 80%+ profile or not

alexistoye commented 11 years ago

Hi Ryan, love it - really like the card approach and think that will make it much better for anything with a touch screen! The only modification is the option to send to sign in as Alex suggested.

Hope this is OK @villarin and doesn't cause too big a complication. Looking at other recruitment sites, they definitely let you have a mini look around before you commit. Think it would be great to build this in now that we have the protection features in place (eg protecting school name)

If at all possible, I would love to get this to the live site as soon as possible. Given the massive IT incident, think we've done remarkably well at keeping to the release schedule :-)

villarin commented 11 years ago

Hi @pythondave

I have checked the response format for the /jobs api method and the right name for the property is "type" (can change the name to something better).

Below are the possible values that can be returned for "type".

1 => full access - applies to admins and teachers with profile >= 80%

2 => restricted - applies to teachers with profile < 80%

3 => anonymous - applies for public users

Number 3 above is my suggested addition - so you can work out whether the request is authenticated or not.

Let me know if that helps and if you need me to change any of the above.

From: Ryan Randall [mailto:notifications@github.com] Sent: 03 December 2013 15:35 To: pythondave/th-frontend Cc: villarin Subject: Re: [th-frontend] User story: As a signed-in user, I can search and filter jobs (#35)

I see, thanks.

In addition to this, I'd like to know whether or not they're logged in, so I can show/hide the login wording accordingly. Is that possible? How am I best to get/derive that?

Thanks again, Ryan

On 3 December 2013 15:25, villarin notifications@github.com wrote:

Href="/me" would do - this will either take the current teacher to the tpep or to the login page if not authenticated

Reply to this email directly or view https://github.com/pythondave/th-frontend/issues/35#issuecomment-29719582 it on GitHub. https://github.com/notifications/beacon/C6aQ2lOetMBBdndp2ctui7tTY5bdUCGEXJn G-ir-qZDONci1gZtaTRuzyZWEqFPG.gif

pythondave commented 11 years ago

That's perfect - thanks!

On 3 December 2013 22:41, villarin notifications@github.com wrote:

Hi @pythondave

I have checked the response format for the /jobs api method and the right name for the property is "type" (can change the name to something better).

Below are the possible values that can be returned for "type".

1 => full access - applies to admins and teachers with profile >= 80%

2 => restricted - applies to teachers with profile < 80%

3 => anonymous - applies for public users

Number 3 above is my suggested addition - so you can work out whether the request is authenticated or not.

Let me know if that helps and if you need me to change any of the above.

From: Ryan Randall [mailto:notifications@github.com] Sent: 03 December 2013 15:35 To: pythondave/th-frontend Cc: villarin Subject: Re: [th-frontend] User story: As a signed-in user, I can search and filter jobs (#35)

I see, thanks.

In addition to this, I'd like to know whether or not they're logged in, so I can show/hide the login wording accordingly. Is that possible? How am I best to get/derive that?

Thanks again, Ryan

On 3 December 2013 15:25, villarin notifications@github.com wrote:

Href="/me" would do - this will either take the current teacher to the tpep or to the login page if not authenticated

Reply to this email directly or view it on GitHub< https://github.com/pythondave/th-frontend/issues/35#issuecomment-2971 8649> .

Reply to this email directly or view <https://github.com/pythondave/th-frontend/issues/35#issuecomment-29719582

it on GitHub. < https://github.com/notifications/beacon/C6aQ2lOetMBBdndp2ctui7tTY5bdUCGEXJn G-ir-qZDONci1gZtaTRuzyZWEqFPG.gif>

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29759410 .

alexistoye commented 11 years ago

This may be a pointless comment but is it worth including Approved as a type for future use? If this is pointless feel free to ignore it!!! Cheers both!

pythondave commented 11 years ago

Updated: http://pythondave.github.io/th-frontend/3/0.1/spas/jobs/default.html#/

There's now different behaviour for each of the 3 user types.

type 1 => full access - job link opens in a new tab type 2 => restricted - modal opens, 'sign in' wording not shown, since they're logged in type 3 => anonymous - modal opens, 'sign in' wording shown

For prototype purposes, the type is determined randomly whenever a search is done.

@alexistoye - I guess we can easily add an 'approved' type (or other types) if/when the requirements need it.

Feel free to keep the ideas coming :)

Alex-Teacherhorizons commented 11 years ago

Looks great!

Is the pop up working? I can't see it

Thanks,

A

On Tue, Dec 3, 2013 at 11:41 PM, Alexis notifications@github.com wrote:

Hi Ryan, love it - really like the card approach and think that will make it much better for anything with a touch screen! The only modification is the option to send to sign in as Alex suggested.

Hope this is OK @villarin https://github.com/villarin and doesn't cause too big a complication. Looking at other recruitment sites, they definitely let you have a mini look around before you commit. Think it would be great to build this in now that we have the protection features in place (eg protecting school name)

If at all possible, I would love to get this to the live site as soon as possible. Given the massive IT incident, think we've done remarkably well at keeping to the release schedule :-)

— Reply to this email directly or view it on GitHubhttps://github.com/pythondave/th-frontend/issues/35#issuecomment-29726475 .

Alex ReynoldsDirector of Communicationswww.teacherhorizons.com http://www.teacherhorizons.com/+44 7796 511 500 Skype: Alex.teacherhorizons http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfAWatch our video here! http://www.youtube.com/watch?feature=player_embedded&v=sJxrQIC8yfA http://www.teacherhorizons.com/ http://www.linkedin.com/groups/Teacherhorizons-3782926?trk=myg_ugrp_ovr http://goog_21780030/ http://www.facebook.com/teacherhorizons http://goog_21780039/ http://www.twitter.com/teacherhorizons https://plus.google.com/b/101365118875012446063/101365118875012446063/posts http://www.teacherhorizonsblog.com/

alexistoye commented 11 years ago

@Alex-Teacherhorizons - you need to refresh the page (can take a few times) as it simulates the experience for different users (eg someone above 80% or under 80%)

The only think that needs a tweak is adding the possibility to sign up too - then reckon ready to sign off and integrate to beta! :-)