search

pythonindia / inpycon2018

PyCon India 2018 site
https://in.pycon.org/2018/
Other
110 stars 61 forks source link

Keynote dropdown under Speaker has a weird blue background #185

Closed varundey closed 6 years ago

varundey commented 6 years ago
screen shot 2018-09-12 at 1 12 55 pm

Click on Speakers and then click on Keynotes. It shows a weird blue background color for the list item that does not go with the theme.

varundey commented 6 years ago

I see that for other list items, the background is white. I would like to take it up. #dibs

ananyo2012 commented 6 years ago

@varundey Can you try doing a hard reload ?

varundey commented 6 years ago

@ananyo2012 i tried loading in firefox private window with cache disabled. issue still persists

varundey commented 6 years ago

Tickets section has the same issue. Debugged and seems to be coming from Bootstrap CSS.

screen shot 2018-09-12 at 2 28 25 pm
bhansa commented 6 years ago

@varundey Is it browser specific? Are you able to reproduce the same in Chrome as well?

varundey commented 6 years ago

@bhansa yep!

screen shot 2018-09-12 at 10 46 59 pm
realslimshanky commented 6 years ago

I think the problem can be resolved by explicitly styling :hover pseudo-class of the drop down items. @varundey would you like to send a quick fix in pr for this?

ananyo2012 commented 6 years ago

I still can't reproduce the issue. I checked in 3 browsers Chrome canary v71, Firefox Quantum v62 and Microsoft edge v38. @pythonindia/pycon-2018-team Can others verify in their browsers ?

bhansa commented 6 years ago

Same here, not reproducible

On Thu, 13 Sep 2018, 13:47 Ananyo Maiti, notifications@github.com wrote:

I still can't reproduce the issue. I checked in 3 browsers Chrome canary v71, Firefox Quantum v62 and Microsoft edge v38. @pythonindia/pycon-2018-team https://github.com/orgs/pythonindia/teams/pycon-2018-team Can others verify in their browsers ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pythonindia/inpycon2018/issues/185#issuecomment-420923411, or mute the thread https://github.com/notifications/unsubscribe-auth/AJRf7B-GfhCtVgL09WLYocvr_S19FkJqks5uahSOgaJpZM4Wk0mX .

realslimshanky commented 6 years ago

@ananyo2012 @bhansa maybe it's a platform/browser issue of some sort. If @varundey is getting the effect may be more folks can also see the same. So, it would be better if he can provide us with a quick fix for the respective platform/browser. Others will not be harmed by this change :)

varundey commented 6 years ago

I tested this on latest versions of Firefox, Firefox developer edition and Chrome both Mac and PC. Here are the steps to repro:

  1. Click on Speakers, it'll open a dropdown
  2. Click on Keynotes, the page will autoscroll and dropdown will get closed
  3. Reclick on Speakers, you'll notice the blue background on Keynotes

Please see #186

bhansa commented 6 years ago

The steps made this clear now, thanks for the quick fix.

ananyo2012 commented 6 years ago

Ah thanks a lot. Now I can reproduce it. Got it form the steps.

ananyo2012 commented 6 years ago

Closing this. Fixed in #186